4 Comments
User's avatar
тна Return to thread
Peaceful Dave's avatar

An interesting and strong solution, put the allocations in a big allocation.

When people are already working ridiculous hours to meet their schedule, expecting real code reviews is nonsense. Sadly, the best code reviews that I did was tasked with resolving problems in someone's released code where I was not punished for spending time on it. Justification for your quest to fix software development.

Expand full comment
Chris Fox's avatar

I review every commit unless the project is simply too vast. I used a tool called GitKraken that is simply superb. Sometimes I even download the branch and run the changes through a debugger but usually I can just eyeball it and catch bugs.

I bet I was the only one on the MS campus who knew about the Heap API. Everyone else just used alloc and free.

Expand full comment
Peaceful Dave's avatar

I didn't know about it either.

Expand full comment
Chris Fox's avatar

Part of the C/C++ Win32/Win64 API.

HHEAP HeapCreate,

HeapFree,

HeapAlloc,

HeapDestroy

It allocates in pages, usually 4K, and releases the entire page set with that last call, and everything allocated with it. It would take an effort to leak memory.

Expand full comment